feat: support PHP 8.4 and 8.5 in parallel - #18
Merged
Conversation
Widen php to ^8.4 and require z-engine as 8.4.x-dev || 8.5.x-dev so Composer resolves the engine-bindings line matching the running minor. Run tests and PHPStan on both minors in CI, and update the README and CLAUDE.md to describe the parallel-minor policy instead of the 8.4 pin. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y5XNnAjcG8xSxun92V23Sm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
composer.json:php: ^8.4andlisachenko/z-engine: 8.4.x-dev || 8.5.x-dev, plusminimum-stability: dev+prefer-stable: true(root-level requirement for the dev branches). Composer resolves the engine-bindings line matching the running minor — verified locally:8.4.x-devon PHP 8.4,dev-master(aliased8.5.x-dev) on PHP 8.5.PHP_MINOR: 8.4env with a['8.4', '8.5']matrix for the tests and PHPStan jobs (coding standards stays single-version).8.4 | 8.5, requirements and installation sections rewritten for the parallel-minor policy.Validation
Full
.phptsuite run locally on both minors with fresh installs:8.4.x-dev): OK, 12 testsdev-master): OK, 12 testsThe
do_operation/compare/create_objecthandlers work on both z-engine lines. PHPStan and php-cs-fixer could not be run locally (their dists are GitHub-API-only, which the sandbox egress blocks) — CI covers both.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y5XNnAjcG8xSxun92V23Sm
Generated by Claude Code